Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Please avoid node dependency to "natives" module #119

Open
bpasero opened this issue Apr 10, 2018 · 3 comments
Open

Please avoid node dependency to "natives" module #119

bpasero opened this issue Apr 10, 2018 · 3 comments

Comments

@bpasero
Copy link

bpasero commented Apr 10, 2018

Hi,

I am a developer on VSCode and wanted to reach out to inform you that this extension is either using or having a dependency to a node module "natives" that will soon no longer be supported in VSCode once we updated to node.js 8.x (as part of our Electron 2.0 update which is planned for the near term).

The full graph is:

└─┬ unzip@0.1.11
  └─┬ fstream@0.1.31
    └─┬ graceful-fs@3.0.11
      └── natives@1.1.0 

It would be great if this dependency could be avoided by either not depending on it anymore or updating the dependencies to newer versions so that this module is no longer pulled in.

As soon as any code in your extension (including node_modules) calls require("natives") we will throw an exception to prevent this module from getting loaded.

If this is just a devDependency and the module is never loaded in production, then you can ignore this issue and just close it!

More details in microsoft/vscode#47569

Thanks!
Ben
VSCode Team

@bpasero
Copy link
Author

bpasero commented Apr 10, 2018

A good alternative node module to unzip seems to be unzip-stream, a fork of the unzip library with similar API.

@erocheleau
Copy link
Collaborator

Okay thanks for the information, we do need that unzip library in production to unzip files (duh) on the result of a command.

We will look at updating that dependency.

@bpasero
Copy link
Author

bpasero commented May 3, 2018

@erocheleau thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants