Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec.conform_valid does not propogate beyond collection, dict, and tuple specs #51

Open
chrisrink10 opened this issue Apr 10, 2020 · 0 comments · May be fixed by #67
Open

Spec.conform_valid does not propogate beyond collection, dict, and tuple specs #51

chrisrink10 opened this issue Apr 10, 2020 · 0 comments · May be fixed by #67
Assignees
@chrisrink10
Labels
bug Something isn't working

Comments

@chrisrink10
Copy link
Contributor

It is not currently possible to propogate calls to Spec.conform_valid beyond a collection, dictionary, or tuple spec, because that call simply calls Spec.conformer directly (which ultimately ends up calling Spec.conform on any child Specs, rather than Spec.conform_valid).
@chrisrink10 chrisrink10 added the bug Something isn't working label Apr 10, 2020
@chrisrink10 chrisrink10 self-assigned this Apr 15, 2020
@chrisrink10 chrisrink10 linked a pull request Apr 21, 2020 that will close this issue
Draft
@chrisrink10 chrisrink10 linked a pull request Apr 21, 2020 that will close this issue
Spec.conform_valid can now propogate through nested Specs #67
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisrink10 chrisrink10

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Spec.conform_valid can now propogate through nested Specs coverahealth/dataspec
1 participant
@chrisrink10