Resolve discussions

Author: Paulo Barbosa

Diff for: src/coverlet.console/Program.cs

@@ -208,7 +208,14 @@ static int Main(string[] args)
 
                     foreach (var thresholdValue in thresholdValues)
                     {
-                        thresholdTypeFlagValues[thresholdTypeFlagQueue.Dequeue()] = double.Parse(thresholdValue);
+                        if (double.TryParse(thresholdValue, out var value))
+                        {
+                            thresholdTypeFlagValues[thresholdTypeFlagQueue.Dequeue()] = value;
+                        }
+                        else
+                        {
+                            throw new Exception($"Invalid threshold value must be numeric");
+                        }
                     }
                 }
                 else

Diff for: src/coverlet.core/CoverageResult.cs

@@ -149,23 +149,22 @@ public ThresholdTypeFlags GetThresholdTypesBelowThreshold(CoverageSummary summar
                         double line = summary.CalculateLineCoverage(Modules).AverageModulePercent;
                         double branch = summary.CalculateBranchCoverage(Modules).AverageModulePercent;
                         double method = summary.CalculateMethodCoverage(Modules).AverageModulePercent;
-                        var numModules = Modules.Count;
-
+                        
                         if ((thresholdTypes & ThresholdTypeFlags.Line) != ThresholdTypeFlags.None)
                         {
-                            if ((line / numModules) < thresholdTypeFlagValues[ThresholdTypeFlags.Line])
+                            if (line < thresholdTypeFlagValues[ThresholdTypeFlags.Line])
                                 thresholdTypeFlags |= ThresholdTypeFlags.Line;
                         }
 
                         if ((thresholdTypes & ThresholdTypeFlags.Branch) != ThresholdTypeFlags.None)
                         {
-                            if ((branch / numModules) < thresholdTypeFlagValues[ThresholdTypeFlags.Branch])
+                            if (branch < thresholdTypeFlagValues[ThresholdTypeFlags.Branch])
                                 thresholdTypeFlags |= ThresholdTypeFlags.Branch;
                         }
 
                         if ((thresholdTypes & ThresholdTypeFlags.Method) != ThresholdTypeFlags.None)
                         {
-                            if ((method / numModules) < thresholdTypeFlagValues[ThresholdTypeFlags.Method])
+                            if (method < thresholdTypeFlagValues[ThresholdTypeFlags.Method])
                                 thresholdTypeFlags |= ThresholdTypeFlags.Method;
                         }
                     }

Diff for: src/coverlet.msbuild.tasks/CoverageResultTask.cs

@@ -157,7 +157,14 @@ public override bool Execute()
 
                     foreach (var threshold in thresholdValues)
                     {
-                        thresholdTypeFlagValues[thresholdTypeFlagQueue.Dequeue()] = double.Parse(threshold);
+                        if (double.TryParse(threshold, out var value))
+                        {
+                            thresholdTypeFlagValues[thresholdTypeFlagQueue.Dequeue()] = value;
+                        }
+                        else
+                        {
+                            throw new Exception($"Invalid threshold value must be numeric");
+                        }
                     }
                 }
                 else
@@ -182,7 +189,6 @@ public override bool Execute()
 
                 var coverageTable = new ConsoleTable("Module", "Line", "Branch", "Method");
                 var summary = new CoverageSummary();
-                int numModules = result.Modules.Count;
 
                 var linePercentCalculation = summary.CalculateLineCoverage(result.Modules);
                 var branchPercentCalculation = summary.CalculateBranchCoverage(result.Modules);