Skip to content

Commit 7e86d1e

Browse files
committed
add comment for NuGet.Frameworks dependency
1 parent 32df82b commit 7e86d1e

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

Directory.Packages.props

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,20 @@
1919
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="7.0.1" />
2020
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
2121
<PackageVersion Include="Microsoft.TestPlatform.ObjectModel" Version="17.5.0" />
22+
<!-- Microsoft.TestPlatform.ObjectModel has a dependency to NuGet.Frameworks with specific version -->
23+
<!-- https://github.com/microsoft/vstest/blob/9a0c41811637edf4afe0e265e08fdd1cb18109ed/src/Microsoft.TestPlatform.ObjectModel/Microsoft.TestPlatform.ObjectModel.csproj#L35-->
24+
<!-- wrong configuration will create "build\coverlet.msbuild.targets(72,5): error : Unable to read beyond the end of the stream." -->
25+
<!--
26+
vstest 17.5 version /scripts/build/TestPlatform.Dependencies.props
27+
https://github.com/microsoft/vstest/blob/81f87947b316a4faf2bcb5b8c8fa1591baafcc39/scripts/build/TestPlatform.Dependencies.props#L57
28+
vstest 17.8 version
29+
NuGetFrameworksVersion is defined here https://github.com/microsoft/vstest/blob/9a0c41811637edf4afe0e265e08fdd1cb18109ed/eng/Versions.props#L94C1-L94C1
30+
-->
31+
<PackageVersion Include="NuGet.Frameworks" Version="5.11.5" />
2232
<PackageVersion Include="Mono.Cecil" Version="0.11.5" />
2333
<PackageVersion Include="Moq" Version="4.18.4" />
2434
<PackageVersion Include="Newtonsoft.Json" Version="13.0.1" />
2535
<PackageVersion Include="NuGet.Packaging" Version="6.6.1" />
26-
<!-- test Msbuild.Test_MultipleTargetFrameworkReport_CoverletOutput_Folder_FileNameWithExtension_SpecifyFramework fails on CI but works locally with .NET 8.0 proview -->
27-
<!-- build\coverlet.msbuild.targets(72,5): error : Unable to read beyond the end of the stream. -->
28-
<!--<PackageVersion Include="NuGet.Frameworks" Version="6.6.1" />-->
29-
<PackageVersion Include="NuGet.Frameworks" Version="5.11.5" />
30-
<!-- nuget packages coverlet.collector and coverlet.msbuild should target multiple framework runtimes NetFrameworkMinimum: net462 and TFW libraries: netstandard2.0; command line tool: net6.0 -->
31-
<!-- similar to this https://github.com/microsoft/MSBuildSdks/blob/main/Directory.Packages.props-->
3236
<PackageVersion Include="ReportGenerator.Core" Version="5.1.23" />
3337
<PackageVersion Include="LinqKit.Microsoft.EntityFrameworkCore" Version="7.1.4" />
3438
<PackageVersion Include="System.Collections.Immutable" Version="7.0.0" />

0 commit comments

Comments
 (0)