Skip to content

Specifying threshold level for each threshold type. #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arun-subramanian-1 opened this issue Apr 10, 2019 · 6 comments
Closed

Specifying threshold level for each threshold type. #379

arun-subramanian-1 opened this issue Apr 10, 2019 · 6 comments
Assignees
Labels
feature-request New feature request

Comments

@arun-subramanian-1
Copy link

Threshold command-line option /P:Threshold seems to use a single value for all threshold type.
I would like to specify different threshold level for each threshold types.

like 100% method but give like 50% branch for ex.

/p:Threshold=\"50,100\" /p:ThresholdType=\"branch,method\"

But this doesnt work, it throws error

.... error : The minimum branch coverage is below the specified 50100  ....
.... error : The minimum method coverage is below the specified 50100 ....
 > coverlet --version
Cross platform .NET Core code coverage tool
1.5.0.0
 > 
@MarcoRossignoli
Copy link
Collaborator

@arun-subramanian-1
Copy link
Author

arun-subramanian-1 commented Apr 27, 2019

@MarcoRossignoli Created a pull request for this option

#385

@MarcoRossignoli MarcoRossignoli added the enhancement General enhancement request label Apr 27, 2019
@MarcoRossignoli MarcoRossignoli added feature-request New feature request and removed enhancement General enhancement request labels Sep 12, 2019
@oherik
Copy link

oherik commented Sep 25, 2019

I would also like to request this feature. It would be very valuable for me to have, since my team has specified a minimum test coverage for both lines and branches (with different percentages for each type).

@MarcoRossignoli
Copy link
Collaborator

cc: @tonerdo #385 (comment)

@FourierFormed
Copy link

I would also find this feature very useful.

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Apr 3, 2021

closed in #1123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants