Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check API settings values before storing them in the SettingsProvider #48

Open
andreaforni opened this issue Aug 26, 2020 · 0 comments · May be fixed by #49
Open

fix: check API settings values before storing them in the SettingsProvider #48

andreaforni opened this issue Aug 26, 2020 · 0 comments · May be fixed by #49
Assignees
Labels
bug Something isn't working

Comments

@andreaforni
Copy link
Contributor

The SettingsProvider loads the backend's setting configuration (apiSettings) into its state.
Many of those fields are parsed into numbers using Number function (here and there). There is no check to see if the field is undefined before converting it, this may result in NaN values stored inside the provider.

@andreaforni andreaforni added the bug Something isn't working label Aug 26, 2020
@andreaforni andreaforni self-assigned this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant