Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove en-IE from Intl.NumberFormat and create a formatNumber function #50

Open
andreaforni opened this issue Aug 27, 2020 · 0 comments · May be fixed by #51
Open

Refactor: remove en-IE from Intl.NumberFormat and create a formatNumber function #50

andreaforni opened this issue Aug 27, 2020 · 0 comments · May be fixed by #51
Assignees

Comments

@andreaforni
Copy link
Contributor

andreaforni commented Aug 27, 2020

In different parts of the app (for example here, here and here) the following line of code is used to format numbers:

new Intl.NumberFormat('en-IE').format(<value>)

We should:

  • remove the hardcoded en-IE locale and read the current used by the app so that the numbers can be formatted accordingly
  • extract a formatNumber to reduce duplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant