Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default revenue share for partner fees #502

Open
fhenneke opened this issue Jan 27, 2025 · 1 comment
Open

Update default revenue share for partner fees #502

fhenneke opened this issue Jan 27, 2025 · 1 comment

Comments

@fhenneke
Copy link
Collaborator

According to https://snapshot.box/#/s:cow.eth/proposal/0xbafee087f3a1d5757e44a72fa76e8624ce212623153816a936a8888741485ef5 we need to update the default share for partners.

The implementation should probably switch to something like a dict with a default value and other values set explicitly.

The current implementation only uses two values and only has an exception for one partner address:

partner_fee_cut: float
partner_fee_reduced_cut: float
reduced_cut_address: str

@pierceroberts
Copy link

Hey @fhenneke !
Going of the docstrings:

    partner_fee_cut -- fraction of partner fees withheld from integration partners
    partner_fee_reduced_cut -- reduced amount withheld from partner specified as reduced_cut_address
    reduced_cut_address -- partner fee recipient who pays the reduced cut partner_fee_reduced_cut

Do do you want:

partner_fee_cut: float = 0
partner_fee_reduced_cut: float = 0
reduced_cut_address: Dict[str, str] = {}

Or are you looking to add these fields into dictionary with the keys being the reduced_cut_address and values bign the partner_reduced cuts?
Like so:

partner_fee_cut: float = 0
reduced_cut_address: Dict[str, float] = {} # where str is the address and the float is the partner_fee_reduced_cut

Could you please add more context here?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants