Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Accept Path as arguments #33

Closed
pykong opened this issue Feb 25, 2020 · 1 comment · Fixed by #34
Closed

Feature request: Accept Path as arguments #33

pykong opened this issue Feb 25, 2020 · 1 comment · Fixed by #34

Comments

@pykong
Copy link
Contributor

pykong commented Feb 25, 2020

We write the year 2020: Pythonistas have largely adopted the use of the pathlib module as a more convenient way to perform file system operation that old stinkin os.path and its comrades.

Hence it would be great if all of pathspec function would accept Path objects or iterables thereof as arguments, compared to plain strings.

Putting a conversion to a string via str(my_path) at the right places is all it takes to make it work.

@pykong pykong changed the title Feature request: Accept Path as Feature request: Accept Path as arguments Feb 25, 2020
@cpburnz
Copy link
Owner

cpburnz commented Feb 27, 2020

@pykong That would be a useful addition. I'll review your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants