[expr.static.cast], [over.call.object] Replace 'greater cv-qualification' with 'more cv-qualified' #7050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisenwave
force-pushed
the
more-cv-qualified
branch
from
71c0a21
to
9206390
Compare
Eisenwave
changed the title
jensmaurer
reviewed
Jun 5, 2024
Eisenwave
force-pushed
the
more-cv-qualified
branch
from
9206390
to
237904c
Compare
AlisdairM
reviewed
Jun 16, 2024
source/expressions.tex
Outdated
| if \cvqual{cv2} is the | ||
| same cv-qualification as, or greater cv-qualification than, | ||
| \cvqual{cv1}. If \tcode{B} is a virtual base class of \tcode{D} | ||
| if \cvqual{cv2}~\tcode{D} is at least as cv-qualified as \cvqual{cv1}~\tcode{B}. |
There was a problem hiding this comment.
I am concerned that const int "is at least as cv-qualified" as volatile int, but not "the same or greater".
There was a problem hiding this comment.
Agreed. We only have a partial order here.
There was a problem hiding this comment.
The PR now uses the wording "equally as or more cv-qualified than" (also fixes [expr.cond]), which should be unambiguous even with only a partial order.
There was a problem hiding this comment.
Progress, but I remain concerned that "equally as cv-qualified" does not mean "has the same cv-qualification" due to our partial ordering.
…cv-qualification' with 'more cv-qualified'
Eisenwave
force-pushed
the
more-cv-qualified
branch
from
237904c
to
67dab85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7048.
Generally, the strategy is to replace "same cv-qualification, or greater cv-qualification" with "at least as cv-qualified", which is much shorter and more natural. "At least as" is arguably not a defined term (unlike "more cv-qualified"), but I believe it naturally stems from the defined term. If we really wanted to, we could defined "at least as cv-qualified" and "more cv-qualified" more strictly, but I don't believe it's entirely necessary to do so.
Note that there is precedent for "at least as cv-qualified" in https://eel.is/c++draft/expr.cond#4.3.1