Skip to content

Conversation

@jensmaurer
Copy link
Member

Partially addresses #4228

@jensmaurer jensmaurer changed the title [thread] Add page break Page breaks (jmaurer) Sep 25, 2020
@jensmaurer jensmaurer force-pushed the pgbr branch 2 times, most recently from 787fe4c to 2d41be6 Compare September 29, 2020 06:22
@jensmaurer jensmaurer force-pushed the pgbr branch 3 times, most recently from 76f53b4 to 6ff58ca Compare September 29, 2020 22:24
@jensmaurer jensmaurer marked this pull request as ready for review September 30, 2020 21:17
@zygoloid
Copy link
Member

zygoloid commented Oct 1, 2020

26.8: I wonder if we could keep the foo, fool, foof overloads together on the same page. Not a big deal, though, and I don't think we should do this for C++20.

32.5.4.4.2: The widowed class-head is unfortunate. But I think we can live with this if a newpage here causes problems. (Similar in 32.5.5.3, but I think that'd be too much to add a newpage before if fixing 32.5.4.4.2 doesn't affect it.)

32.9.10.2/17: I think we should move the "Error conditions:" line onto the next page with its bullets.

Other than that, Clause 25-32 look good. Thanks!

@jensmaurer
Copy link
Member Author

jensmaurer commented Oct 1, 2020

I've addressed the [thread.] stuff. Regrettably, there was quite a bit of fall-out; needs re-review. Force-pushed.

@jensmaurer jensmaurer requested a review from zygoloid October 1, 2020 10:27
Copy link
Member

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@zygoloid zygoloid merged commit 914092d into cplusplus:c++20 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants