P2976R1 Freestanding Library: algorithm, numeric, and random #7706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-craig
reviewed
Mar 13, 2025
Comment on lines
+193
to
+198
| void uninitialized_default_construct(ExecutionPolicy&& exec, // freestanding-deleted, | ||
| NoThrowForwardIterator first, // see \ref{algorithms.parallel.overloads} |
There was a problem hiding this comment.
I don't think this comment is aligned with the other // freestandings. Same for others in this file.
There was a problem hiding this comment.
This seems fine, do you have anything specific in mind?
tkoeppe
force-pushed
the
motions-2025-02-lwg-10
branch
3 times, most recently
from
7beb045 to
bdced58
Compare
tkoeppe
force-pushed
the
motions-2025-02-lwg-10
branch
from
bdced58 to
9f05d3f
Compare
| @@ -1601,10 +1602,12 @@ | |||
| \ref{iterators} & Iterators library & \tcode{<iterator>} \\ \rowsep | |||
| \ref{ranges} & Ranges library & \tcode{<ranges>} \\ \rowsep | |||
| \ref{algorithms} & Algorithms library & \tcode{<algorithm>}, \tcode{<numeric>} \\ \rowsep | |||
| \ref{execpol} & Execution policies & \tcode{<execpol>} \\ \rowsep | |||
There was a problem hiding this comment.
Oops, the header should be <execution>. I'll open a PR for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7669.
Fixes cplusplus/papers#1644.