Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0261 C++ Distributed Counters #563

Open
brycelelbach opened this issue Jul 12, 2019 · 5 comments
Open

P0261 C++ Distributed Counters #563

brycelelbach opened this issue Jul 12, 2019 · 5 comments
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 concurrency-ts-2 Ship vehicle: Concurrency TS 2 LEWG Library Evolution needs-revision Paper needs changes before it can proceed size - large paper size estimate TS Ship vehicle: TS

Comments

@brycelelbach
Copy link

brycelelbach commented Jul 12, 2019

P0261R3 C++ Distributed Counters (Lawrence Crowl)

@brycelelbach brycelelbach added the LEWGI Library Evolution Incubator label Jul 12, 2019
@brycelelbach
Copy link
Author

brycelelbach commented Jul 12, 2019

Kona 2019-02 LEWGI Minutes

P0261R3 Distributed Counters

Champion: Lawrence Crowl

Minute Taker: Guy Somberg

Start Overview: 9:12

Why do we need *_array?

Make it work for more types. For the integral types that std::atomic is specialized for, use std::atomic. Otherwise, use a std::mutex.

Start Discussion: 9:15

Start Polling: 9:40

POLL: Make the following changes:

  • Explore making general_counter::load const.
  • Make general_counter::general_counter(Integral) explicit.
  • Add is_lockfree and is_always_lockfree to all the counter types.
  • Make general_counter_array::general_counter_array(size_type) constexpr and explicit.
  • Make general_counter_array::size and counter_broker_array::size const.

NO OBJECTION TO UNANIMOUS CONSENT

POLL: Rename general_counter* to (vote for as many as you like):

Option Votes
general_counter 1
distributed_counter 6
counter 0
integral_counter 1
atomic_counter 6
shared_counter 3
synchronizing_counter 0

Attendance: 11

POLL: Explore supporting a wider range of types, not just Integrals that have std::atomic specializations.

Strongly For Weakly For Neutral Weakly Against Strongly Against
2 2 1 1 1

Attendance: 11

That has no consensus.

SA: Our time is limited.

POLL: We want general_counter_array and counter_broker_array for the initial version of this feature.

Strongly For Weakly For Neutral Weakly Against Strongly Against
0 3 3 1 0

Attendance: 11

End: 9:50

@brycelelbach brycelelbach added the needs-revision Paper needs changes before it can proceed label Jul 12, 2019
@wg21bot
Copy link
Collaborator

wg21bot commented Jan 18, 2020

P0261R4 C++ Distributed Counters (Lawrence Crowl)

@wg21bot wg21bot added this to the 2020-02 milestone Jan 18, 2020
@jensmaurer jensmaurer removed the needs-revision Paper needs changes before it can proceed label Jan 21, 2020
@cor3ntin
Copy link

@brycelelbach has SG1 seen this?

@brycelelbach brycelelbach added LEWG Library Evolution EWGI Evolution Incubator B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 concurrency-ts-2 Ship vehicle: Concurrency TS 2 TS Ship vehicle: TS ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list and removed LEWGI Library Evolution Incubator labels Aug 25, 2020
@brycelelbach
Copy link
Author

@cor3ntin Yes, they've seen it multiple times, and forwarded it to us.

@jensmaurer jensmaurer modified the milestones: 2020-02, 2021-telecon Dec 28, 2020
@brycelelbach brycelelbach added the library-evolution-deferred Ready for review, but should not be scheduled label Mar 25, 2021
@brycelelbach brycelelbach removed the ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list label May 25, 2021
@brycelelbach brycelelbach added the size - large paper size estimate label Aug 1, 2021
@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@cor3ntin cor3ntin added the EWG Evolution label Feb 22, 2022
@brycelelbach brycelelbach removed EWG Evolution LEWG Library Evolution EWGI Evolution Incubator library-evolution-deferred Ready for review, but should not be scheduled labels Sep 23, 2022
@brycelelbach
Copy link
Author

Marking as needs revision as this is a bit out of date.

@brycelelbach brycelelbach reopened this Sep 23, 2022
@brycelelbach brycelelbach added LEWG Library Evolution needs-revision Paper needs changes before it can proceed labels Sep 23, 2022
@jensmaurer jensmaurer removed this from the 2022-telecon milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 concurrency-ts-2 Ship vehicle: Concurrency TS 2 LEWG Library Evolution needs-revision Paper needs changes before it can proceed size - large paper size estimate TS Ship vehicle: TS
Projects
None yet
Development

No branches or pull requests

4 participants