-Wsign-conversion is redundant

[benjamin051000]

cmake_template/cmake/CompilerWarnings.cmake

Line 54 in d19d892

-Wsign-conversion # warn on sign conversions

According to Clang diagnostics (https://clang.llvm.org/docs/DiagnosticsReference.html#wconversion), -Wconversion controls -Wsign-conversion. This is the same as GCC (https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wsign-conversion), although this only applies to the ${CLANG_WARNINGS} section.

I haven't tried removing -Wsign-conversion and seeing if it still catches it, but perhaps someone else can to verify this behavior. Per the spec, it should be a redundant flag.

[benjamin051000]

Also spotted here in cppbestpractices

https://github.com/cpp-best-practices/cppbestpractices/blob/b8b1d72dff751465ac1ca288bf6818a9f9330ccd/02-Use_the_Tools_Available.md?plain=1#L118