-
-
Notifications
You must be signed in to change notification settings - Fork 0
use napi-rs #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use napi-rs #39
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 14 14
Lines 3144 3144
=======================================
Hits 3097 3097
Misses 47 47 ☔ View full report in Codecov by Sentry. |
@shenxianpeng I created an org on npmjs.org named cpp-linter. If you want, I can send you an invite. Once I get the CI working, the node binding will be published to npm in the
I suppose I could add support for more platforms/targets (once I understand how), but these should be sufficient enough to use in a Typescript-based GitHub action. I think there might be a way to export the exposed For now, I'm concerned about the dependence on openSSL (from the libgit2 rust binding)... |
Sure, why not? Feel free to send the invite. thank you. |
My npm account is also @shenxianpeng |
b459b55
to
cffadac
Compare
Ok, I think I have wrapped my head around the release process. yarn version --new-version <tag>
git add --all
git commit -m "bump version to <tag>"
git push
git tag <tag>
git push origin refs/tags/<tag>
Using
|
make a yarn workspace update cargo lock
bf38613
to
c5ccdcf
Compare
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces significant updates across various files in the project, including the addition of an Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Initial node binding using napi-rs.
I'm opening this just to test the generated (and customized) CI workflow...
I might have to make this repo a npm workspace project because it is already a cargo workspace.
Summary by CodeRabbit
New Features
cpp-linter
with support for multiple platforms (Darwin, Linux, Windows).Documentation
Bug Fixes
Chores
.gitignore
and.npmignore
files to improve project cleanliness.