No Windows binaries in the release

[garethr]

The GitHub releases page lists binaries for Linux and Darwin but not Windows. Are there any known issues with Windows support preventing this?

[cppforlife]

Are there any known issues with Windows support preventing this?

just never tried it on windows. if i find a windows machine ill give it a go next week. if you are able to run integration tests on windows and report back that would be also helpful.

[drnic]

Cut Windows CLIs and wait for issues ;)

[cppforlife]

that i can definitely do next week.

[garethr]

I compiled knctl this morning on Windows and will try it out and see if I hit anything. So far so good. A few notes:

• The build instructions don't include mention of dep, so if you just run the scripts or follow the README instructions it will fail due to missing dependencies
• I had to checkout the 0.0.10 tag as trying with master fails to compile due to type issues with the vendored Azure libraries from go-client

I've not had chance to run the e2e tests as they will need some tweaking to be run, eg. in the environment variables with things like the private git repo.

I'll open issues for anything I come across that doesn't work but overall looks good. Thanks.

[cppforlife]

The build instructions don't include mention of dep, so if you just run the scripts or follow the README instructions it will fail due to missing dependencies

shouldnt be necessary to build. all dependencies are vendored in vendor/

 $ cd ~/workspace/

 $ git clone https://github.com/cppforlife/knctl knctl-go/src/github.com/cppforlife/knctl
Cloning into 'knctl-go/src/github.com/cppforlife/knctl'...
remote: Enumerating objects: 1812, done.
remote: Counting objects: 100% (1812/1812), done.
remote: Compressing objects: 100% (1143/1143), done.
remote: Total 6045 (delta 724), reused 1304 (delta 493), pack-reused 4233
Receiving objects: 100% (6045/6045), 7.08 MiB | 3.40 MiB/s, done.
Resolving deltas: 100% (3105/3105), done.
Checking connectivity... done.

 $ cd knctl-go/src/github.com/cppforlife/knctl

 $ export GOPATH=~/workspace/knctl-go/

 $ ./hack/build.sh
+ go fmt ./cmd/... ./pkg/... ./test/...
+ go build ./cmd/...
+ ./knctl version
Client Version: 0.0.10
...

[garethr]

I had a few output formatting issues when running on Windows, noting here:

$ knctl basic-auth-secret create ...
?[1mName?[0m  docker-hub
?[1mType?[0m  kubernetes.io/basic-auth

$ knctl service-account create ...
?[1mName?[0m  docker-hub-service-account

[cppforlife]

@garethr latest release (https://github.com/cppforlife/knctl/releases/tag/v0.1.0) includes windows binary now.

[cppforlife]

closing this issue, created separate issue for windows colors.