Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale message to fit in Timer #1067

Closed
cpvalente opened this issue Jun 11, 2024 · 3 comments
Closed

Scale message to fit in Timer #1067

cpvalente opened this issue Jun 11, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers UI

Comments

@cpvalente
Copy link
Owner

cpvalente commented Jun 11, 2024

The issue

Currently, the timer view shows the messages from the Editor in a fixed size.
This means that, with enough text content, the view overflows and the messages are not readable.

too much stuff in timer

Since this is screen specific, there is no way for the editor to know of the overflow, which makes matters worse

The task

The issue task is to modify the message display to always fit the message on the screen

Follow here for the code entrypoint
We also have a copy of useFitText which could potentially be used here

@cpvalente cpvalente added good first issue Good for newcomers UI labels Jun 11, 2024
@asharonbaltazar
Copy link
Collaborator

asharonbaltazar commented Jun 25, 2024

Clarification: the text should always fit the screen regardless of how many words it contains. If it contains too many words, the text size should be resized until it can fit the screen. Does that sound correct?

Is there a limit to the characters? What if someone pastes the entirety of War and Peace?

@cpvalente
Copy link
Owner Author

cpvalente commented Jun 25, 2024

Clarification: the text should always fit the screen regardless of how many words it contains. If it contains too many words, the text size should be resized until it can fit the screen. Does that sound correct?

Is there a limit to the characters? What is someone pastes the entirety of War and Peace?

Hi!

Yes. We should make sure that the text always takes the whole size to fit. The text should be able to break lines as needed though

We don't enforce limits. We likely will need (and want) upper and lower limits on font-size for the algorithm. War and peace might not workout...

I think any reasonable defaults are good enough. If we don't have anything in mind something between 16px-128px sounds good to me

@asharonbaltazar asharonbaltazar self-assigned this Jun 26, 2024
@cpvalente cpvalente mentioned this issue Sep 18, 2024
@cpvalente
Copy link
Owner Author

Done and released in v3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers UI
Projects
None yet
Development

No branches or pull requests

2 participants