Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more prefixes for boolean methods #417

Closed
petertrr opened this issue Oct 16, 2020 · 2 comments · Fixed by #677
Closed

Allow more prefixes for boolean methods #417

petertrr opened this issue Oct 16, 2020 · 2 comments · Fixed by #677
Assignees
@aktsay6
Labels
enhancement New feature or request

Comments

@petertrr
Copy link
Member

Like equals*, equivalent*, or just make it configurable
@petertrr petertrr added the enhancement New feature or request label Oct 16, 2020
@petertrr
Copy link
Member Author

@akuleshov7 what do you think? Now diktat triggers even when equals method is overriden. Also I've seen examples with equivalent* in some projects.

@petertrr
Copy link
Member Author

Also, are*

@aktsay6 aktsay6 self-assigned this Dec 29, 2020
aktsay6 added a commit that referenced this issue Dec 29, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
58cb8fa 
### What's done:
  * Added more prefixes
### Need to be done:
  * Configuration option
  * More tests
aktsay6 added a commit that referenced this issue Dec 29, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
6ff4edb 
### What's done:
  * Added more prefixes
@aktsay6 aktsay6 mentioned this issue Dec 29, 2020
Merged
5 tasks
aktsay6 added a commit that referenced this issue Dec 30, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
0114b9b 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 30, 2020
@aktsay6
feature/more-prefixes-boolean-method(#417)
60cdd40 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 30, 2020
@aktsay6
Merge branch 'master' into feature/more-prefixes-boolean-methods(#417)
161914e 
# Conflicts:
#	diktat-analysis.yml
#	diktat-rules/src/main/resources/diktat-analysis-huawei.yml
#	diktat-rules/src/main/resources/diktat-analysis.yml
aktsay6 added a commit that referenced this issue Dec 30, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
c488882 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 31, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
09ffef9 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 31, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
5ea54c7 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 31, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
8fe878f 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 31, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
2937788 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 31, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
9976e55 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 31, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
568c6af 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 31, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
d6f43bc 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 31, 2020
@aktsay6
feature/more-prefixes-boolean-methods(#417)
f5be6c6 
### What's done:
 * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 31, 2020
@aktsay6
Merge branch 'master' into feature/more-prefixes-boolean-methods(#417)
3e365a9
aktsay6 added a commit that referenced this issue Dec 31, 2020
@aktsay6
Feature. Allow more prefixes for boolean methods (#417) (#677)
62c5a01 
* feature/more-prefixes-boolean-methods(#417)

### What's done:
  * Added more prefixes
  * Configuration option
  * More tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aktsay6 aktsay6

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature. Allow more prefixes for boolean methods (#417) saveourtool/diktat
2 participants
@petertrr @aktsay6