Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain the XLS templates #132

Closed
amihaiemil opened this issue Jan 31, 2018 · 7 comments
Closed

Explain the XLS templates #132

amihaiemil opened this issue Jan 31, 2018 · 7 comments

Comments

@amihaiemil
Copy link
Contributor

I see most of the metrics are implemented in XLS and processed with skeletom.xml?

Can you pls explain such an XLS template? I see most declare variables (e.g. <xsl:variable name="Oi">, inside <xsl:template>, so I assume all that has to be done in a new metric is declare the variables used by said metric, inside the right template, but I am not sure.

@0crat
Copy link
Collaborator

0crat commented Jan 31, 2018

@yegor256/z please, pay attention to this issue

This was referenced Jan 31, 2018
Closed
Closed
@amihaiemil
Copy link
Contributor Author

@skapral Maybe you can ask Yegor to assign this to you. I guess this explanation should remain in this ticket for everyone to see. Surely, I am not the only one who is not familiar with XSL :)

@skapral
Copy link
Contributor

skapral commented Jan 31, 2018

@amihaiemil @yegor256

Actually, I created something similar once ago (#105) and I don't know what to add besides that. XSL templates are just XSL templates which transition one XML (skeleton.xml) to the other (METRIC.XML). There is completely no sacral meaning for jpeek in its variable names and templates. However, I have no idea how to make them more readable.

In my pull request (#130) I used the names from the formula, located in the description. The almost similar names were used in the article describing the metric. I could name it differently without impacting the semantics - if you think that my naming is not transparent enough, don't hesitate to give me a remark there (but I would really appreciate a concrete proposal).

However, sacral meaning for jpeek have the input skeleton.xml and resulting METRIC.xml. For transparency, it would worth creating schemas with documenting annotations for them (#133).

@amihaiemil
Copy link
Contributor Author

@skapral No, this ticket was not about your PRs, they are fine from my point of view. I wanted an explanation so I can understand how to implement metrics with XSL :)

@yegor256
Copy link
Member

@amihaiemil you need this book: http://amzn.to/2GyG3en

@0crat
Copy link
Collaborator

0crat commented Feb 7, 2018

Job gh:yegor256/jpeek#132 is not assigned, can't get start time

@0crat
Copy link
Collaborator

0crat commented Feb 7, 2018

Job #132 was not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants