Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not error for INDIVIDUAL reports for multiple SDEs. Centralize the logic for converting report types to eval types. #595

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Do not error for INDIVIDUAL reports for multiple SDEs. Centralize the logic for converting report types to eval types. #595

merged 4 commits into from
Nov 25, 2024

Conversation

lukedegruchy
Copy link
Contributor

  • Do not error for INDIVIDUAL reports for multiple SDEs.
  • Centralize the logic for converting report types to eval types.
  • New and updated tests

Closes #592

@lukedegruchy
Do not error out when building an INDIVIDUAL report for multiple SDEs…
d0b8875 
…. Centralize the logic for converting report types to eval types.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

Formatting check succeeded!

@lukedegruchy lukedegruchy marked this pull request as ready for review November 22, 2024 20:00
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.70%. Comparing base (38872a3) to head (085d0b2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../cqf/fhir/cr/measure/r4/R4MultiMeasureService.java 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #595      +/-   ##
============================================
+ Coverage     73.63%   73.70%   +0.06%     
  Complexity       19       19              
============================================
  Files           362      363       +1     
  Lines         18950    18986      +36     
  Branches       2539     2538       -1     
============================================
+ Hits          13954    13993      +39     
  Misses         3634     3634              
+ Partials       1362     1359       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Capt-Mac Capt-Mac merged commit 70801bc into master Nov 25, 2024
8 checks passed
@Capt-Mac Capt-Mac deleted the ld-20241121-evaluate-measure-non-async-null-type-null-subject-take-2 branch November 25, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Capt-Mac Capt-Mac Capt-Mac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Measure Evaluation reportType behavior
2 participants
@lukedegruchy @Capt-Mac