Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Do not let user save certain buffer settings that causes crashes. #582

Open
Fjara-h opened this issue Nov 20, 2024 · 0 comments
Open

Comments

@Fjara-h
Copy link

Fjara-h commented Nov 20, 2024

There is no feedback from the app or system upon crashing or inputting values in the buffer settings that loading a stream with them cause problems. I only checked this via usb debugging using:

adb logcat --buffer=crash 

I've encountered the below exceptions, however more testing should be done to determine which other settings and values will cause this crash. These occured on different runs, the first was when Min Buffer was less than Buffer for playback, and the second was when Min Buffer was less than Rebuffer

java.lang.RuntimeException: Unable to create service com.github.andreyasadchy.xtra.ui.player.PlaybackService: java.lang.IllegalArgumentException: minBufferMs cannot be less than bufferForPlaybackMs

java.lang.RuntimeException: Unable to create service com.github.andreyasadchy.xtra.ui.player.PlaybackService: java.lang.IllegalArgumentException: minBufferMs cannot be less than bufferForPlaybackAfterRebufferMs

Alternatively changing the way the setting is chosen (like a two-sided slide bar) could help alleviate the need to do checking, but it may get too complicated with more than 2 settings it would affect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant