Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 30 #37

Closed
wants to merge 4 commits into from
Closed

Hotfix 30 #37

wants to merge 4 commits into from

Conversation

webremote
Copy link
Contributor

@webremote webremote commented Dec 13, 2016

  • should fix CSS styles aren't loaded #30
  • documented and improved the htmlcache_filename function
  • improved htmlcache_checkCache function by respecting settings.json file, improvements for v1.1 marked
    • disableHeaders (default false)
    • defaultMimetype (default text/html)
    • defaultMimetypeCharset (default UTF-8)
    • enableFootprint (default false)

* should fix #30 
* documented and improved the `htmlcache_filename` function
* improved `htmlcache_checkCache` function by respecting `settings.json` file, improvements for v1.1 marked
* * `disableHeaders` (default `false`)
* * `defaultMimetype` (default `text/html`)
* * `defaultMimetypeCharset` (default `UTF-8`)
* * `enableFootprint` (default `false`)
@KoenRijpstra
Copy link
Contributor

This doesn't seem right. In my opinion this plugin should never cache the following files 'css', 'js','jpg', 'jpeg', 'gif', 'bmp', 'png'. It looks like there is something wrong with the server/craft config in issue #30.

@webremote
Copy link
Contributor Author

not going to merge

@webremote webremote closed this Dec 26, 2016
@webremote webremote deleted the hotfix-30 branch December 26, 2016 09:09
@webremote webremote restored the hotfix-30 branch December 26, 2016 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS styles aren't loaded
2 participants