Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Base URL Generation Using Deprecated URL #128

Closed
iamderrick opened this issue Oct 4, 2021 · 4 comments · Fixed by #157
Closed

S3 Base URL Generation Using Deprecated URL #128

iamderrick opened this issue Oct 4, 2021 · 4 comments · Fixed by #157
Assignees
Labels

Comments

@iamderrick
Copy link

When the plugin automatically tries to generate the base URL for a publically accessible S3 bucket, it uses the old path-style model rather than the new virtual-hosted model. This older URL model does not work with newer S3 buckets. See: https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/

@iamderrick iamderrick added the bug label Oct 4, 2021
@andris-sevcenko
Copy link
Contributor

I personally have no preference here, but you should know that @timkelty will have an opinion.

Context: #34

@timkelty
Copy link
Contributor

timkelty commented Oct 5, 2021

Yeah, as long as it's https by default, prob should go with the virtual-hosted version.
@iamderrick happy to review a PR, otherwise we'll get to it soon.

@brianjhanson
Copy link
Contributor

It looks like the plans to deprecate the old path-style have been put on pause somewhat indefinitely. Either way, I've opened a PR to address this.

@brandonkelly
Copy link
Member

Amazon S3 1.3.1 (Craft 3) and 2.0.2 (Craft 4) are out now, and use the new URL format by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants