Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x]: The "Twig\Extension\EscaperExtension::addSafeClass()" method is deprecated #15873

Closed
leevigraham opened this issue Oct 10, 2024 · 3 comments
Closed

[5.x]: The "Twig\Extension\EscaperExtension::addSafeClass()" method is deprecated #15873

leevigraham opened this issue Oct 10, 2024 · 3 comments
Assignees
@brandonkelly
Labels
bug

Comments

@leevigraham
Copy link
Contributor

What happened?

Description

addSafeClasses is deprecated and throws deprecation warnings in PHPUnit

https://twig.symfony.com/doc/3.x/deprecated.html#extensions

https://github.com/craftcms/cms/blob/5.x/src/web/View.php#L389-L390

Image

Craft CMS version

5.4.7.1

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions
@brandonkelly brandonkelly self-assigned this Oct 10, 2024
@brandonkelly
Copy link
Member

Thanks for pointing that out! Fixed for the next release.

@leevigraham
Copy link
Contributor Author

@brandonkelly I spotted another twig deprecation but I can't remember what it was… I'll try and recreate it.

@brandonkelly
Copy link
Member

Craft 5.4.8 is out with that initial one. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandonkelly brandonkelly

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leevigraham @brandonkelly