Fix MigrationHelper::dropAllForeignKeysToTable #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MigrationHelper is a little complex. Can you send us a database and test code that demonstrates the issue? support@craftcms.com |
|
Thanks for taking a look, should be a mail landing shortly. |
|
Looks legit to me... thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like
dropAllForeignKeysToTablewas silently failing, which was causing some fails indropTabledue to FK constraints.The extra
updateTypeanddeleteTypecolumns weren't being excluded from the column list, and it seems like it was collecting all the columns, across both FKs and tables, while trying to remove them.Noticed there's already a helper to cull out the non-column data from a FK array, so I've just swapped that into place.