Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Entry Modal : PDF Image Size #3209

Closed
magnessjo opened this issue Aug 16, 2018 · 1 comment
Closed

Asset Entry Modal : PDF Image Size #3209

magnessjo opened this issue Aug 16, 2018 · 1 comment

Comments

@magnessjo
Copy link
Contributor

Description

An asset entry modal appear incorrectly for PDF.

For images, the modal appears correctly with an image follow by the fields.

For PDF, the modal appears with a generic PDF image but it sized to be 1000px and scales out of it parent container. The parent container (image-preview-container) has a set height of 190px so an easy fix is to just set the child to a height of 190px as well. A white background on the parent with the child element using background-image set to contain would be better to remove an possible responsive issues.

See attachments.

screen shot 2018-08-16 at 3 01 08 pm
screen shot 2018-08-16 at 2 44 20 pm

Steps to reproduce

  1. Save a PDF file and double click to edit

Additional info

  • Craft version: Craft Pro 3.0.20
  • PHP version: 7.1.8
  • Database driver & version: MySQL 5.5.56
  • Plugins & versions:
@brandonkelly
Copy link
Member

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants