Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing assets: filename settings don't work #750

Closed
darylknight opened this issue Sep 21, 2020 · 2 comments
Closed

Importing assets: filename settings don't work #750

darylknight opened this issue Sep 21, 2020 · 2 comments
Labels

Comments

@darylknight
Copy link

As a workaround to #749, I thought I'd try just importing the assets on their own first instead of also assigning them to entries at the same time. The source URLs all have the same filename, but no matter what settings I use, it doesn't appear to be working correctly.

Example feed:

[
  {
    "app_id": "105450",
    "title": "Age of Empires III",
    "file_name": "age-of-empires-iii.jpg",
    "image_url": "https://steamcdn-a.akamaihd.net/steam/apps/105450/capsule_616x353.jpg"
  },
  {
    "app_id": "236870",
    "title": "HITMAN",
    "file_name": "hitman.jpg",
    "image_url": "https://steamcdn-a.akamaihd.net/steam/apps/236870/capsule_616x353.jpg"
  }
]

If I set the Filename field to something unique, it imports all the assets - but on the filesystem itself, they're all called the original remote filename, appended with something unique: capsule_616x353-[insert random date and timestamp here].jpg.

Import settings:

image

Import result in Craft:

image

Actual files on mac:

image

It looks like it technically does the right thing in Craft, but the files themselves aren't named correctly, which is why all the thumbnails are broken. You also then can't delete the image files using Craft, because they don't match the real filenames.

Additional info

  • Craft version: 3.5.11.1
  • PHP version: 7.4.8
  • Plugins & versions: FeedMe 4.2.3
@angrybrad
Copy link
Member

Resolved in 5345cfd and will be in the next release.

@brandonkelly
Copy link
Member

Feed Me 4.3.0 is out now with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants