Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

apply shouldn’t edit hosts file if no domains changed #117

Closed
brandonkelly opened this issue May 7, 2020 · 2 comments
Closed

apply shouldn’t edit hosts file if no domains changed #117

brandonkelly opened this issue May 7, 2020 · 2 comments
Assignees
@jasonmccallister
Labels
enhancement Not really required but improves quality of life
Milestone
v2

Comments

@brandonkelly
Copy link
Member

Currently nitro apply always prompts for your password and updatse updates the hosts file, even if there’s nothing to change in it.

Ideally, Nitro should be aware of whether anything just changed that would require a change to the hosts file, and skip that step if not.
@brandonkelly brandonkelly added the enhancement Not really required but improves quality of life label May 7, 2020
@jasonmccallister jasonmccallister self-assigned this May 21, 2020
@jasonmccallister jasonmccallister modified the milestone: 1.0 May 21, 2020
@brandonkelly brandonkelly mentioned this issue May 27, 2020
Closed
@jasonmccallister
Copy link
Contributor

@brandonkelly I think we can close this out, since we are forcing a remove and re-add during apply?

@jasonmccallister jasonmccallister added this to the next milestone Dec 28, 2020
@jasonmccallister
Copy link
Contributor

With v2, the apply command will not prompt for host file changes if nothing has new has been added.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonmccallister jasonmccallister

Labels
enhancement Not really required but improves quality of life
Projects
None yet
Milestone
v2
Development

No branches or pull requests
2 participants
@brandonkelly @jasonmccallister