Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Default behavior when remove db #190

Closed
yanickrecher opened this issue Jul 27, 2020 · 2 comments
Closed

Default behavior when remove db #190

yanickrecher opened this issue Jul 27, 2020 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yanickrecher
Copy link

Description

It's maybe not that important, but i just saw that.
When i try to remove a Database which was created with nitro, i will be asked if i really want to remove a specific db.

The Default Value is [no]. If i type "any chars" and hit ENTER the database will removed any way.
I know the prompt didn't require a "yes" but it could be a bit more save. Otherwise the question if i really want to remove the db could also be omit.

Steps to reproduce

  1. nitro db remove
  2. 3
  3. ENTER
@yanickrecher yanickrecher added the bug Something isn't working label Jul 27, 2020
@jasonmccallister
Copy link
Contributor

Thank you for reporting @yanickrecher, I'm going to add this to the list for the next release.

@jasonmccallister jasonmccallister self-assigned this Jul 30, 2020
@jasonmccallister jasonmccallister added this to the 1.0 milestone Jul 30, 2020
@jasonmccallister
Copy link
Contributor

@yanickrecher I just tagged our prompt library with the latest version. We were looking for any characters in "yes". The library will now only check return if its "y" or "yes" and not any of the characters.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants