Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

upload_max_filesize is not being set #207

Closed
jasonmccallister opened this issue Aug 22, 2020 · 6 comments
Closed

upload_max_filesize is not being set #207

jasonmccallister opened this issue Aug 22, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@jasonmccallister
Copy link
Contributor

Description

Referencing this comment (#201 (comment)) the upload_max_filesize is not being set to the provided value.

Steps to reproduce

  1. nitro php iniset upload_max_filesize 20M
  2. nitro php iniget upload_max_filesize

Additional info

  • Nitro version: 1.0.1
  • Multipass version: 1.4
@sa3dany
Copy link
Contributor

sa3dany commented Aug 27, 2020

It is actually being set (confirmed inside vm) but nitro php iniget upload_max_filesize is not reporting updated value for some reason.

@jasonmccallister
Copy link
Contributor Author

@sa3dany I just confirmed this and pushed a bug fix for iniset. I found the issue with iniget and looking at the best option for resolving that as well.

@mmorkt
Copy link

mmorkt commented Oct 5, 2020

@jasonmccallister is there any solution or workaround for this? Got the same problem with max_input_vars.

[User] ~ % nitro php iniset max_input_vars 2000
Successfully changed the ini setting for max_input_vars to 2000

[User] ~ % nitro php iniget max_input_vars
The setting "max_input_vars" is currently set to 1000

PHP-info shows that max_input_vars = 1000
Running the latest Multipass 1.4, Nitro 1.0.1 and updated the machine

@harryfk
Copy link

harryfk commented Oct 5, 2020

Same issue here, also on the latest versions, upgraded from one of the early betas.

@harryfk
Copy link

harryfk commented Oct 5, 2020

@mmorkt @jasonmccallister Any idea how I would set a PHP variable manually? I tried editing the php.ini inside the VM directly, restarted everything, but no dice (in /etc/php/7.4/cli/php.ini).

@jasonmccallister
Copy link
Contributor Author

@mmorkt I'm preparing a release with a lot of changes around php iniget and php iniset that will resolve these issues. I think the release will go out tomorrow when I am done giving it the once over.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants