-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: js style import support #12
Conversation
just tested this, and it works! :) |
Any chance for a readme update? |
@knownasilya, yeah, nice catch! I'm planning to add more tests and then write down readme update |
@lifeart thanks for all the work here! Just wanted to give you heads up that we've got a big deadline early next week, so it's likely we won't have a chance to review this until after then. But don't take the silence as lack of interest! |
Hey there @davewasmer - wondering if this PR is still in play? Would love to try this out in Octane :) |
@lifeart I thing the last thing holding this up is our hesitance with the MU part, since that's an ended experiment. |
Using lifeart/ember-language-server#12 it's possible to implement ELS support for this feature, for example: find text content in template parse it using babel parser resolve component name and return it back |
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MU Support for #10
Octane imports style
Classic imports style