Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19 #22

Closed
sovtec opened this issue Jun 29, 2022 · 6 comments
Closed

1.19 #22

sovtec opened this issue Jun 29, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@sovtec
Copy link

sovtec commented Jun 29, 2022

I really like the idea of this plugin, is it any chance you could update it to 1.19 and support the new HoverText instead of the old depreciated one? :)

I have a feel you have a updated version, just not commited 😅

Would be epic if you could help out

@sovtec sovtec added the enhancement New feature or request label Jun 29, 2022
@crashdemons
Copy link
Owner

crashdemons commented Jun 29, 2022

Did you try this pre-release https://github.com/crashdemons/DisplayItem-Spigot/releases/tag/v2.9.10 ?
It probably will still have deprecated code, but it has been working for us on 1.19

EDIT: I'm really trying to find any examples using the new HoverEvent method but everything I can find uses the old one instead of the Content version. I could probably use Item as the Content, but I don't see any clean way to convert ItemStack to Item without the mess I'm already doing...

EDIT2: I did find one outdated example that uses nmsItem.getTag() but it doesn't seem that CraftItemStack decided to expose that method, so we have the same problem as with nmsItem.save() where it is obfuscated differently every version...

@sovtec
Copy link
Author

sovtec commented Jun 30, 2022

Seems to be working altho it's not optimal, I really like this plugin. EvModder told me about it because I talked to him about creating a plugin like this but was confused about the hover event.

Also tried looking into the HoverEvent, and I found this: BungeeCord-Chat 1.16-R0.4 API altho that might also be a little old

@crashdemons
Copy link
Owner

I'm using that API (just not the newest HoverEvent constructor) and I've read what little it shows, but it doesn't really answer the questions I had.

@sovtec
Copy link
Author

sovtec commented Jun 30, 2022

Wish i knew how the new hover component worked lol.

Unrelated but related issue/request

I am using this on my server but players with striketrugh nicknames have the strike displayed all the way in the command send from this plugin including after it's supposed to stop.

Any sulution to this? Not super important tho.

@crashdemons
Copy link
Owner

crashdemons commented Jun 30, 2022

This is a known issue since about 1.15/1.16 but I haven't identified why. It seems like the bungeechat formatter is ignoring the &r (reset formatting) code when a hover component is embedded.

The ticket: #21

One potential solution is to manually modify the chat component structure myself...

@sovtec
Copy link
Author

sovtec commented Jun 30, 2022

I mean it's not an issue tho. Only moderators on my server can use strikethrough. Again love this plugin, have a nice day.

@sovtec sovtec closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants