Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with conventional-changelog #172

Closed
dora-gt opened this issue Oct 28, 2019 · 2 comments
Closed

Issue with conventional-changelog #172

dora-gt opened this issue Oct 28, 2019 · 2 comments

Comments

@dora-gt
Copy link

dora-gt commented Oct 28, 2019

Hi,

I wanted to use cargo release with conventional-changelog but there was a problem.

If we use cargo release in a workspace, it would try to tag with like [crate-name]-[semver]. On the other hand, conventional-changelog tries to gain commit logs, finding tags named like just [semver]. So it is not be processed properly.

There might be some solutions:

  1. Provide a way to tag without crate name when releasing a workspace, specifying main crate. The only main crate would be tagged as a pure sem-ver.
  2. Provide a way to pass "" (empty string) to the tag-prefix option.
  3. Provide a way to pass a crate version variable to "tag-name" option value.

Or should I just push a tag of a pure sem-ver without any prefixes manually?

@epage
Copy link
Collaborator

epage commented Oct 28, 2019

By default, the root crate is not given a tag-prefix. If you have do not have a root crate in your workspace, then you can override the tag-prefix in your "main" crate to be empty. You can also override tag-name but I'm assuming tag-prefix is preferred.

See https://github.com/sunng87/cargo-release/blob/master/docs/reference.md#configuration

@dora-gt
Copy link
Author

dora-gt commented Oct 28, 2019

Ohhhhh! I see! thank you so much🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants