Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help message is slightly messed up #212

Closed
ckaran opened this issue May 11, 2020 · 7 comments · Fixed by crate-ci/clap-cargo#13
Closed

Help message is slightly messed up #212

ckaran opened this issue May 11, 2020 · 7 comments · Fixed by crate-ci/clap-cargo#13

Comments

@ckaran
Copy link

ckaran commented May 11, 2020

Running cargo help release yields the following (abbreviated):

$ cargo help release
cargo-release-release 0.13.4
Cargo flags for selecting crates in a workspace

USAGE:
    cargo-release release [OPTIONS] [--] [level-or-version]

Normally, we use this tool as cargo release, even though cargo-release should be in the path. cargo-release-release is not in my path, so I suspect that there is a bug there.

@sunng87
Copy link
Collaborator

sunng87 commented May 11, 2020

This is a minor issue with the cli parser we use. Are you interested in investigation and making a PR for this?

@ckaran
Copy link
Author

ckaran commented May 11, 2020

@sunng87 I wish I had the time to, but I can't. I'm sorry.

@epage
Copy link
Collaborator

epage commented May 11, 2020

The help string is coming from clap-cargo, we could workaround it in clap-cargo like we did in clap-verbosity-flag, see clap-rs/clap-verbosity-flag#21

@epage
Copy link
Collaborator

epage commented May 11, 2020

The underlying structopt bug is TeXitoi/structopt#333

@epage
Copy link
Collaborator

epage commented May 11, 2020

New clap-cargo released. Give it a try!

@ckaran
Copy link
Author

ckaran commented May 11, 2020

@epage Just pull the latest (14ecbe336ae1ed7205b4a7f5f4f9783b76b132d5), and this is what I get:

$ cargo run --release -- release --help
    Finished release [optimized] target(s) in 0.06s
     Running `target/release/cargo-release release --help`
cargo-release-release 0.13.5-alpha.0

USAGE:
    cargo-release release [OPTIONS] [--] [level-or-version]

Would I see something different if this were installed rather than run from the command line?

@epage
Copy link
Collaborator

epage commented May 11, 2020

With the latest clap-cargo it is left to cargo-release

but at least it isn't saying "Cargo flags for selecting crates in a workspace"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants