Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to post comments to a pull request in the GitHub Action #1036

Open
yu-iskw opened this issue Jun 14, 2024 · 2 comments
Open

Support to post comments to a pull request in the GitHub Action #1036

yu-iskw opened this issue Jun 14, 2024 · 2 comments
Labels
A-gh-action C-enhancement Category: Raise on the bar on expectations help-wanted Help wanted!

Comments

@yu-iskw
Copy link

yu-iskw commented Jun 14, 2024

Overview

GitHub allows us to post comments with suggestions to a pull request. As far as I am concerned, the current implementation of the GitHub Action scans all files no matter what file we change. It would be great to post comments with suggestions only to changed files using the Action.

https://docs.github.com/en/rest/pulls/comments?apiVersion=2022-11-28#create-a-review-comment-for-a-pull-request

Expected behavior

We can configure the mode to scan all files or to post comments with suggestions in the Action. By doing so, we can improve typos more easily.

@epage
Copy link
Collaborator

epage commented Jun 14, 2024

There are two parts to this that I want to better understand their relationship

  • don't scan all
  • post comment

Why do you see those as related?

Also, like #778, we should have reporting and we have an idea for improving reporting with sarif.

@epage epage added C-enhancement Category: Raise on the bar on expectations A-gh-action S-triage Status: New; needs maintainer attention. help-wanted Help wanted! and removed S-triage Status: New; needs maintainer attention. labels Feb 19, 2025
@epage
Copy link
Collaborator

epage commented Feb 19, 2025

With #594 closed, the way I see this being done is having our action provide a sarif report to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-gh-action C-enhancement Category: Raise on the bar on expectations help-wanted Help wanted!
Projects
None yet
Development

No branches or pull requests

2 participants