Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A dictionary with brand name typos #1045

Closed
szepeviktor opened this issue Jun 23, 2024 · 4 comments
Closed

A dictionary with brand name typos #1045

szepeviktor opened this issue Jun 23, 2024 · 4 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Jun 23, 2024

Would it be possible to start a custom dictionary with brand names?

I meet these

Github -> GitHub
HashiCorp -> HashiCorp
Wordpress -> WordPress
Big Sur -> Big Sur
@epage
Copy link
Collaborator

epage commented Jun 25, 2024

Correcting these would be blocked on #795 and #899.

@szepeviktor
Copy link
Contributor Author

Thank you for your response.

So I should keep my default config file with these brand names.

[default]
extend-ignore-re = [
    "\\bBig Sur\\b",
]

[default.extend-identifiers]
"Github" = "GitHub"
"HashiCorp" = "HashiCorp"
"Wordpress" = "WordPress"

@epage
Copy link
Collaborator

epage commented Jun 25, 2024

If you are concerned for these as identifiers, rather than words, that its a bit different. However, I don't how much consensus there is on these oddly cased names being used as actual identifiers in code (e.g. github vs git_hub). If someone has a type named Github, I'm hesitant to correct that to GitHub.

@szepeviktor
Copy link
Contributor Author

All right. I keep this list on my computer.

@szepeviktor szepeviktor closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants