Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad case when used with cert #883

Closed
j2gg0s opened this issue Dec 13, 2023 · 1 comment
Closed

Bad case when used with cert #883

j2gg0s opened this issue Dec 13, 2023 · 1 comment

Comments

@j2gg0s
Copy link

j2gg0s commented Dec 13, 2023

error: `TEH` should be `THE`
  --> ./pilot/pkg/model/jwks_resolver.go:316:174
    |
316 |       "p": "7EK8xaN7qCdWCeQ1ptXWvuc6qotZc6oD-j1ecgel9FqmfkmaioVEbEAfP_N73QAjw-sU60sK3XK8LV4fkGUoJV-MDvmiCzy3wUPe-adSaTCxFykgOm6SPA9NKCqAh8lUm6GUm9RZkjwkv4xzZ8pJjng3d74WXx7zhTEH6yi4E00",
    |                                                                                                                                                                              ^^^
    |

Can we ignore strings longer than a certain length?

@epage
Copy link
Collaborator

epage commented Dec 13, 2023

typos has no concept of a string literals as it is programming language agnostic.

Within that string literal, I think the longest segment is 70 characters which it can be reasonable in some ecosystems to have identifiers that are that long or longer (our base64 detection code does not match values that look like <=90 character identifiers).

#484 is about a heuristic for ignoring things that look like identifiers but are garbage while we have #316 for excluding lines. Closing in favor of those.

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants