-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MongoDB I/O] Export doesn't write things to stdout #210
Comments
Thank you. Maybe this bug has been introduced while wrapping migr8 into But also, if there is a bug in migr8 about the issue you are observing, we should fix it. |
Hi. I think this problem has been addressed with the recently landed bugfix and improvement patch, so I am closing this. Thank you very much for your report, and please re-open if you think the problem still exists. Otherwise, please enjoy the fixed package. 🙏 |
In
cratedb-toolkit/cratedb_toolkit/io/mongodb/export.py
Line 105 in b7b8010
sys.stdout.buffer
but the only usage incratedb-toolkit/cratedb_toolkit/io/mongodb/core.py
Line 118 in b7b8010
BytesIO
object, so in reality we never throw the documents to the stdout.Meaning that as per explained in https://cratedb-toolkit.readthedocs.io/io/mongodb/migr8.html, we cannot
migr8 export ... > data.json
If we dummy fix this, we still get the header in the file, any tool taking advantage of this should take this into consideration.
The text was updated successfully, but these errors were encountered: