Rename of "ta" to "addon" and other fixes

* splunk::ta renamed to splunk::addon
* splunk::addon::input marked as private
* template syntax clean up
* concat for addon input made conditional to prevent blank file

Author: crayfishx

manifests/addon.pp

@@ -0,0 +1,65 @@
+#
+# Defined type: splunk::addon
+#
+# This define sets up a TA (Technology Addon) for Splunk.  It (optionally)
+# installed a package, and configures input forwarders in 
+# $SPLUNK_HOME/etc/apps/<app name>/local/inputs.conf
+#
+# Examples
+#
+# splunk::addon { 'search':
+#   package_manage => false,
+# }
+#
+# splunk::addon::input { 'monitor:///var/log/messages':
+#   attributes => {
+#     'index' => 'server_t',
+#   },
+# }
+#
+# Alternatively you can feed inputs directly into splunk::addon using the
+# inputs parameter (useful if you are configuring from Hiera)
+#
+#
+# splunk::addon { 'search':
+#   package_manage => false,
+#   inputs          => {
+#     'monitor:///var/log/messages' => {
+#       'attributes' => {
+#         'index' => 'server_t',
+#       }
+#     }
+#   }
+# }
+#
+define splunk::addon (
+  $splunk_home    = '/opt/splunkforwarder',
+  $package_manage = true,
+  $package_name   = undef,
+  $inputs         = {},
+) {
+
+
+  if ( $package_manage ) {
+    validate_string($package_name)
+    package { $package_name:
+      ensure => installed,
+      before => File["${splunk_home}/etc/apps/${name}/local"],
+    }
+  }
+
+  file { "${splunk_home}/etc/apps/${name}/local":
+    ensure => directory,
+  }
+
+  if $inputs {
+    concat { "splunk::addon::inputs_${name}":
+      path    => "${splunk_home}/etc/apps/${name}/local/inputs.conf",
+      require => File["${splunk_home}/etc/apps/${name}/local"]
+    }
+  
+    create_resources('splunk::addon::input', $inputs, {"addon" =>  $name })
+  }
+  
+}
+

manifests/addon/input.pp

@@ -0,0 +1,17 @@
+# Private defined type callled by splunk::addon
+
+define splunk::addon::input (
+  $addon,
+  $attributes={},
+) {
+
+  assert_private()
+
+  concat::fragment { "splunk::addon::input::${addon}::${name}:":
+    target  => "splunk::addon::inputs_${addon}",
+    content => template('splunk/addon/_input.erb'),
+    order   => '10',
+  }
+}
+
+

manifests/forwarder.pp

@@ -84,7 +84,7 @@
   }
 
   # Declare addons
-  create_resources('splunk::ta', $addons)
+  create_resources('splunk::addon', $addons)
 
   # Declare inputs and outputs specific to the forwarder profile
   create_resources( 'splunkforwarder_input',$forwarder_input)

manifests/ta.pp

@@ -1,7 +1,5 @@
 [<%= @name %>]
-<%
-@attributes.each do |key,val|
--%>
+<% @attributes.each do |key,val| -%>
 <%= key %>=<%= val %>
 <% end -%>