Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diun image remove --all command appears to have no effect #478

Closed
adhawkins opened this issue Aug 30, 2021 · 2 comments · Fixed by #519
Closed

diun image remove --all command appears to have no effect #478

adhawkins opened this issue Aug 30, 2021 · 2 comments · Fixed by #519

Comments

@adhawkins
Copy link

adhawkins commented Aug 30, 2021

Looking at the source, it appears that the command doesn't make any reference to the 'all' parameter.

Behaviour

Steps to reproduce this issue

  1. run 'diun image remove --help' - observe '--all' option
  2. run 'diun image remote --all' - error reported about missing 'image' parameter

Expected behaviour

All images should be removed

Actual behaviour

diun image remove --help
Usage: diun image remove --image=STRING

Remove an image manifest from database.

Flags:
 -h, --help            Show context-sensitive help.
      --version

      --grpc-authority="127.0.0.1:42286"
                        Link to Diun gRPC API.
      --image=STRING    Image to remove.
      --all             Remove all manifests from the database.
diun image remove --all
Usage: diun image remove --image=STRING

Remove an image manifest from database.

Run "diun image remove --help" for more information.

diun: error: missing flags: --image=STRING

Configuration

@adhawkins adhawkins changed the title diun image remove --all command appear to have no effect diun image remove --all command appears to have no effect Aug 30, 2021
@crazy-max
Copy link
Owner

@adhawkins Yes this flag is not yet implemented. Was thinking of using prune command instead.

@adhawkins
Copy link
Author

Ok, it's no big deal. I was just experimenting with a few things and spotted that command. Thought I'd post a reminder that you haven't implemented it yet. Perhaps at least remove it from the help until it actually does something?

Thanks for a very useful utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants