Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add riscv64 FreeBSD support code #165

Closed
clausecker opened this issue Feb 16, 2023 · 4 comments
Closed

Please add riscv64 FreeBSD support code #165

clausecker opened this issue Feb 16, 2023 · 4 comments

Comments

@clausecker
Copy link

clausecker commented Feb 16, 2023

Trying to compile github.com/ferama/rospo on riscv64 FreeBSD 13.1.

github.com/creack/pty
# github.com/creack/pty
vendor/github.com/creack/pty/pty_freebsd.go:53:20: undefined: fiodgnameArg
vendor/github.com/creack/pty/pty_freebsd.go:66:12: undefined: _C_SPECNAMELEN
vendor/github.com/creack/pty/pty_freebsd.go:69:9: undefined: fiodgnameArg

go version says go version go1.20 freebsd/riscv64

Please add the missing code.

@adamnyc12
Copy link

github.com/creack/pty

github.com/creack/pty

vendor/github.com/creack/pty/pty_freebsd.go:53:20: undefined: fiodgnamearg
vendor/github.com/creack/pty/pty_freebsd.go:66:12: undefined: _c_specnamelen
vendor/github.com/creack/pty/pty_freebsd.go:69:9: undefined: fiodgnamearg

@clausecker
Copy link
Author

Here's the result of running go tool cgo -godefs types_freebsd.go on a riscv64-freebsd machine if that helps:

// Code generated by cmd/cgo -godefs; DO NOT EDIT.
// cgo -godefs types_freebsd.go

package pty

const (
        _C_SPECNAMELEN = 0xff
)

type fiodgnameArg struct {
        Len     int32
        Buf     *byte
}

@creack
Copy link
Owner

creack commented Oct 26, 2023

Closed by #168

@creack creack closed this as completed Oct 26, 2023
@clausecker
Copy link
Author

Hm weird, the file you committed has a different value for _C_SPECNAMELEN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants