Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irelevant releases build on sentry #68

Open
feryardiant opened this issue Nov 9, 2023 · 0 comments
Open

Irelevant releases build on sentry #68

feryardiant opened this issue Nov 9, 2023 · 0 comments
Labels
backlog Potential item under consideration for a product business process The method a company uses to accomplish routine activities deployment Deployment related things feature request There's a missing piece integration When multiple functionalities should works together

Comments

@feryardiant
Copy link
Contributor

Describe the bug

Pada 067f706 saya tambahkan konfigurasi untuk integrasi sourcemap ke sentry

/**
* @see https://www.npmjs.com/package/@sentry/vite-plugin
*/
sentryVitePlugin({
org: env.SENTRY_ORG,
project: env.SENTRY_PROJECT,
authToken: env.SENTRY_AUTH_TOKEN,
}),

Dimana dalam konfigurasi tersebut, setiap kali kita jalankan pnpm build sentry akan meng-upload sourcemap dari front-end kita agar error report yang kita dapatkan bisa lebih relevan dan akurat. Bahkan dari mekanisme tersebut ada sentry bot yang langsung comment di commit atau PR letak sumber error tersebut.

Dan di implementasi tersebut sentry juga akan membuat release tiap kali build

image

Yang mana menurut ku ini kurang sesuai dengan peruntukan feature "Sentry Release" itu sendiri. Dimana kriteria rilis dalam hal ini adalah :

  • Deployment ke server
  • Release versi menggunakan git tag
    Sedangkan yang dilaporkan atau dicatat di sentry adalah build yang dilakukan di local tiap engineer. Tentu ini tidak relevan karena build di local selayaknya adalah bagian dari progress pengerjaan, bukan sebuah release atau distribusi.

Consideration & Idea

Menurutku akan lebih baik jika release generation yang akan dicatat di sentry adalah ketika

  • Workflow deploy di trigger dari push ke main branch, atau
  • Workflow deploy di trigger ketika publikasi release

Sedangkan untuk build di local, sebaiknya gak ada telemetry dan gak ada upload sourcemap ke sentry.

@feryardiant feryardiant added feature request There's a missing piece integration When multiple functionalities should works together deployment Deployment related things business process The method a company uses to accomplish routine activities backlog Potential item under consideration for a product labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Potential item under consideration for a product business process The method a company uses to accomplish routine activities deployment Deployment related things feature request There's a missing piece integration When multiple functionalities should works together
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant