-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-use source file / tarball, etc. #1193
Comments
The problem there is that not every system I'd definitely take a PR that added this, though - that would allow travis-ci builds to cache $NVM_DIR and greatly speed up test runs. |
@ljharb in the meantime, maybe SHA1 first? Or those platforms also don't support SHA1? Since there is https, for the weaker hash, the checksum we can just use to make sure the process or downloading is good, not for the integrity, what do you think? |
SHA1 is no longer used by node as of v4, as you can see here. In other words, we can definitely make it work with node 0.12 and older, and possibly some iojs versions, with SHA-1, and that would be a great start. |
@ljharb I'm not sure if it's a bad idea that bad enough to ignore it, what about we maintain a sha1 list by ourselves? If you won't hate it, we can try to do it automatically. |
I definitely don't want to maintain my own list of anything; we already have enough runtime internet dependencies as it is, and the SHAs of old versions might change and would need to be kept up to date. I'm already working on this; I'm just trying to get some tests passing. |
Nice, any PR / branch that I can look into? Thanks. |
Nothing quite yet. I'll update here when it's ready. |
GOOD |
Can we just download the checksums to verify (if there is) the existing tarball / source file before re-downloading instead of force re-download the files?
The size of nodejs v6.3.1 src tarball is 25MB, the 64-bit binary is 8.7MB, we could save the bandwidth and time.
The text was updated successfully, but these errors were encountered: