Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The filters use URLs to display the filtered resources #270

Open
1 task done
Murdock9803 opened this issue Jun 6, 2024 · 3 comments
Open
1 task done

[Bug] The filters use URLs to display the filtered resources #270

Murdock9803 opened this issue Jun 6, 2024 · 3 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧹 status: ticket work required Needs more details before it can be worked on

Comments

@Murdock9803
Copy link
Member

Description

While choosing any filter for the resources (for ex. Topic = Licenses), the url of the page gets changed from url to url/all/topic=license. So when we press the cross [x] to revert the changes, the page goes to url/all and not on just url.

Reproduction

  1. Go to the Resource Archive site
  2. Click on any of the filters.
  3. Click the [x] alongside your chosen filter.
  4. Now the url has changed from (initially) https://resources.creativecommons.org/ to (finally) https://resources.creativecommons.org/all/?

Expectation

The filtering of resources should follow a class-based system and not the changing of URL. the chosen filters should be toggled as class name in the concerned resources and only those resources will be displayed.

Screenshots

The url normally looks like:
image

After choosing a filter Topic = Licenses:
image

Now clicking on the [x] alongside the chosen filter:
image

Resolution

  • I would be interested in resolving this bug.
@Murdock9803 Murdock9803 added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Jun 6, 2024
@surajguduru
Copy link

Hey @Murdock9803 I would like to work on this issue. Can you assign it to me ?

@Murdock9803
Copy link
Member Author

Hello @surajguduru
The issue is not yet ready to be worked upon. you can see the labels to confirm this.

@possumbilities possumbilities added 🧹 status: ticket work required Needs more details before it can be worked on and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 16, 2024
@possumbilities
Copy link
Contributor

The urls should still update, but they shouldn't be required for the UI to change necessarily.

The approach here needs to be amended slightly I think.

@TimidRobot TimidRobot moved this to Triage in possumbilities Sep 10, 2024
@possumbilities possumbilities moved this from Triage to Backlog in possumbilities Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧹 status: ticket work required Needs more details before it can be worked on
Projects
Status: Backlog
Development

No branches or pull requests

3 participants