Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EsLint issues are not fixed #176

Closed
4 tasks done
iqasim-com opened this issue May 24, 2019 · 1 comment
Closed
4 tasks done

EsLint issues are not fixed #176

iqasim-com opened this issue May 24, 2019 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@iqasim-com
Copy link

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed
  • I'm reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

You have included lint:check and lint:fix in your package.json file, i was expecting there would not have an EsLint issues but i was wrong. There is a lot of linting issues in your theme, if you did not fixed your linting issues i think there is no need to add linting scripts in your package.json

Current Behavior

✖ 489 problems (489 errors, 0 warnings) 5 errors and 0 warnings potentially fixable with the --fix option.
I don't need to manually fix linting issues because its 489 linting errors, which are 484 after run npm run eslint:fix

Failure Information (for bugs)

It's not a bug but i think you should not compromise with quality.

@einazare
Copy link
Contributor

Hello there, @mqasim1990 ,

Thank you for your interest in working with our products.
We'll fix them in our next update.

Best,
Manu

@einazare einazare added bug Something isn't working enhancement New feature or request labels May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants