Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Right side menu does not auto expand #229

Closed
davidmhleung opened this issue Jun 12, 2020 · 4 comments · Fixed by #256
Closed

[Bug] Right side menu does not auto expand #229

davidmhleung opened this issue Jun 12, 2020 · 4 comments · Fixed by #256
Labels
bug Something isn't working

Comments

@davidmhleung
Copy link

Version

1.9.0

Reproduction link

https://demos.creative-tim.com/material-dashboard-pro-react/#/admin/dashboard

Operating System

OSX Catalina

Device

16 inch macbook pro

Browser & Version

Chrome Version 83.0.4103.97 (Official Build) (64-bit)

Steps to reproduce

  1. Go to https://demos.creative-tim.com/material-dashboard-pro-react/#/admin/dashboard
  2. Click on the vertical 3 dot button to get the mini variant drawer
  3. Shrink the window down to a small tablet size viewport so that the left hand drawer disappears and is replaced with the right hand side hamburger menu
  4. Click on the hamburger menu to show the right hand mini drawer.
  5. The mini draw shows some cut off text.

What is expected?

Right hand mini drawer should function the same as the right hand side mini drawer. On hover it should expose the expanded drawer.

What is actually happening?

Currently it shows an in between of a mini drawer and the full size drawer


Solution

Fix the behavior so that both the left and right draw behave the same.

Additional comments

I have screenshots if that is helpful but didn't see a place where I could upload them. Happy to provide by email if needed. Thanks!!!

@davidmhleung
Copy link
Author

davidmhleung commented Jun 12, 2020

Screen Shot 2020-06-12 at 1 04 59 AM
Screen Shot 2020-06-12 at 1 04 34 AM

@einazare
Copy link
Contributor

Hello there, @davidmhleung ,

Thank you for your interest in working with our products and for noticing this issue.
To solve it, please go inside src/assets/jss/material-dashboard-pro-react/components/sidebarStyle.js and change the following bits of codes as follows:
1.Change

  drawerPaperMini: {
    width: drawerMiniWidth + "px!important"
  },

To

  drawerPaperMini: {
    [theme.breakpoints.up("md")]: {
      width: drawerMiniWidth + "px!important"
    }
  },

2.Change

  logoNormalSidebarMini: {
    opacity: "0",
    transform: "translate3d(-25px, 0, 0)"
  },

To

  logoNormalSidebarMini: {
    [theme.breakpoints.up("md")]: {
      opacity: "0",
      transform: "translate3d(-25px, 0, 0)"
    }
  },
  1. Change
  logoNormalSidebarMiniRTL: {
    transform: "translate3d(25px, 0, 0)"
  },

To

  logoNormalSidebarMiniRTL: {
    [theme.breakpoints.up("md")]: {
      transform: "translate3d(25px, 0, 0)"
    }
  },
  1. Change
  itemTextMini: {
    transform: "translate3d(-25px, 0, 0)",
    opacity: "0"
  },

To

  itemTextMini: {
    [theme.breakpoints.up("md")]: {
      transform: "translate3d(-25px, 0, 0)",
      opacity: "0"
    }
  },
  1. Change
  itemTextMiniRTL: {
    transform: "translate3d(25px, 0, 0) !important"
  },

To

  itemTextMiniRTL: {
    [theme.breakpoints.up("md")]: {
      transform: "translate3d(25px, 0, 0) !important"
    }
  },
  1. Change
  collapseItemTextMiniRTL: {
    transform: "translate3d(25px, 0, 0) !important"
  },

To

  collapseItemTextMiniRTL: {
    [theme.breakpoints.up("md")]: {
      transform: "translate3d(25px, 0, 0) !important"
    }
  },

7.Change

  collapseItemTextMini: {
    transform: "translate3d(-25px, 0, 0)",
    opacity: "0"
  },

To

  collapseItemTextMini: {
    [theme.breakpoints.up("md")]: {
      transform: "translate3d(-25px, 0, 0)",
      opacity: "0"
    }
  },

This will do the trick. We will make an update to this product in about 2-3 months and we'll add these changes in that update as well.

Please leave the issue open.

Best,
Manu

@einazare einazare added the bug Something isn't working label Jun 15, 2020
@davidmhleung
Copy link
Author

Thank you @einazare !!!

@davidmhleung
Copy link
Author

Worked like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants