Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Icons: Deprecated: Required parameter $size #131

Closed
ArmReu opened this issue Jan 31, 2022 · 11 comments
Closed

Avatar Icons: Deprecated: Required parameter $size #131

ArmReu opened this issue Jan 31, 2022 · 11 comments

Comments

@ArmReu
Copy link

ArmReu commented Jan 31, 2022

Deprecated: Required parameter $size follows optional parameter $css in .../plugins/Customizer/Helper/DynamicAvatar.php on line 26

Deprecated: Required parameter $size follows optional parameter $css in .../plugins/Customizer/Helper/DynamicAvatar.php on line 47

No avatar image for header or board can be uploaded

image

@creecros
Copy link
Owner

creecros commented Feb 1, 2022

I'm not really maintaining this plug in anymore. sorry.

It sounds like your php version may be too new, try php 7.x

@wlangemeyer
Copy link
Contributor

it's PHP 8 with the kanboard docker image v1.2.22 and I got the same issues/warnings

@creecros
Copy link
Owner

yes, fully aware. would need to prevent null values, as that is no longer valid in php 8. I know exactly how to fix it, just lack the time to do it.

@wlangemeyer
Copy link
Contributor

wlangemeyer commented Mar 18, 2022

hi, I fixed it in this way and it's tested with php 7.4 and 8 and works for me.

. # diff Customizer/Helper/DynamicAvatar.php Customizer/Helper/DynamicAvatar.php.fixed
. 26c26
. < public function dynamic($user_id, $username, $name, $email, $avatar_path, $css = '', $size)
. ---
. > public function dynamic($user_id, $username, $name, $email, $avatar_path, $css = 'avatar-left', $size = 48)
. 47c47
. < public function boardDynamic($user_id, $username, $name, $email, $avatar_path, $css = '', $size)
. ---
. > public function boardDynamic($user_id, $username, $name, $email, $avatar_path, $css = 'avatar-left', $size = 48)

sorry, I'm not familiar with git/github to commit/send you the file...

@creecros
Copy link
Owner

perfect execution. I'll merge your pull request when I get the chance.

@palcarazm
Copy link
Contributor

Fixed by 908de21

@Jieiku
Copy link
Collaborator

Jieiku commented Apr 11, 2022

Pretty sure this was fixed here: #132

(maybe it got fixed twice?)

@creecros
Copy link
Owner

im slacking, and haven't updated any releases in probably a year, so there are plenty of new merges that haven't actually been released.

@Jieiku
Copy link
Collaborator

Jieiku commented Apr 12, 2022

I drafted a new release: https://github.com/creecros/Customizer/releases/tag/1.13.8

and submited a pull request to update the plugin repo: kanboard/website#310

@Jieiku Jieiku closed this as completed Apr 12, 2022
@creecros
Copy link
Owner

you rock, thanks @Jieiku

@Jieiku
Copy link
Collaborator

Jieiku commented Apr 12, 2022

no problem, happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants