Skip to content
This repository has been archived by the owner on Oct 23, 2021. It is now read-only.

Organize the code in modules instead of one big file. #51

Open
creesch opened this issue Aug 3, 2018 · 2 comments
Open

Organize the code in modules instead of one big file. #51

creesch opened this issue Aug 3, 2018 · 2 comments

Comments

@creesch
Copy link
Owner

creesch commented Aug 3, 2018

Currently everything lives in one big file with just a little abstraction. This makes maintenance a bit of a pain and contributions also less likely.

It would probably be beneficial to split out the code in several components. Something along the lines of:

  • start.js would be responsible for
  • discord.js would be responsible for the discord connection side of things.
  • irc-server.js would contain the connection functionality for the server.
  • utils.js would be the home of all the functions responsible for parsing data. Like these lines here and a lot of functionality that now happens directly in the event handlers themselves.

It would be no small task, but it has been on my mind for a while so I might as well make an issue for it.

@SkyLeite
Copy link

SkyLeite commented Apr 2, 2019

On it! https://github.com/RodrigoLeiteF/discordIRCd

Gonna open a PR soon for discussions, but it's still in the early stages.

@creesch
Copy link
Owner Author

creesch commented Apr 2, 2019

Awesome! Looking forward to the PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants