Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all events when matching/filtering #826

Closed
seanvaleo opened this issue Mar 4, 2022 · 2 comments · Fixed by #821
Closed

Show all events when matching/filtering #826

seanvaleo opened this issue Mar 4, 2022 · 2 comments · Fixed by #821
Assignees
Labels

Comments

@seanvaleo
Copy link
Collaborator

Default behavior is to show the last 20 events with scope events unless --all is explicitly specified.

To improve user experience, when we specify one of --source, --sourcetype, --match or --eval we should show all matches by default, not a limit of 20. This avoids confusion, where the user might expect more matches for their query.

It should still be possible to display a subset of results with the --last option if that is desired.

@seanvaleo seanvaleo added the cli label Mar 4, 2022
@seanvaleo seanvaleo self-assigned this Mar 4, 2022
@seanvaleo
Copy link
Collaborator Author

QA INSTRUCTIONS

Part 1
Do:

docker run --rm -it cribl/scope:<VERSION_ID>
apt update
scope run -- apt install curl -y
scope events
scope events --match fs
scope events --source fs.close
scope events --sourcetype fs
# etc...

Expect:
You see only 20 events with no matching/filtering arguments.
You see more than 20 events with matching/filtering arguments.

@seanvaleo seanvaleo linked a pull request Mar 7, 2022 that will close this issue
@jrcheli
Copy link
Contributor

jrcheli commented Mar 10, 2022

I bugathoned this with v1.0.2-rc0 on 10-Mar-2022. Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants