Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Resolve version information from online resources #17

Closed
asamuzaK opened this issue Nov 8, 2020 · 3 comments
Closed

Proposal: Resolve version information from online resources #17

asamuzaK opened this issue Nov 8, 2020 · 3 comments

Comments

@asamuzaK
Copy link
Contributor

asamuzaK commented Nov 8, 2020

I created a helper module for js2bin.
asamuzaK/js2bin-version-info: Helper module for js2bin. Resolve version information from online resources.

This module gets the latest version(s) for the "build" and "ci" commands from online resources.

  • For the "build" command, it gets the latest version from the js2bin release asset.
    Currently, if the user does not specify a version, it falls back to 10.16.0, but it is not good to let the user use an old version which may contain vulnerability.
  • For the "ci" command, it will compare the js2bin release assets and nodejs LTS, and return a list of nodejs LTS versions that are not included in the assets.
    Currently, you are updating the version each time in the azure-pipeline.yml, but this module will let you free from that work.
    Also, if you add a cron job in the azure-pipeline, you will be able to release the latest assets automatically.

If you are interested in this module, I will send a PR containing this module.
How about it?

@ledbit
Copy link
Collaborator

ledbit commented Nov 12, 2020

That would be pretty useful to ensure that we always build the latest LTS releases - see #7. Looking forward to the PR - thanks!!

@asamuzaK
Copy link
Contributor Author

PR ready. #19

@asamuzaK
Copy link
Contributor Author

It doesn't seem to be reviewed, so I will withdraw the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants